Make UpdateAtomic Delegates scoped and distinct #10673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -82,5 +88,11 @@ public Task UpdateAtomicAsync(Func<Task<TDocument>> updateAsync, Func<TDocument, | |||
|
|
|||
| return Task.CompletedTask; | |||
| } | |||
|
|
|||
| private class UpdateDelegates | |||
There was a problem hiding this comment.
That is called a Tuple, there are nice syntaxes in C# for that, and you can even do a struct record otherwise, but tuples are better here.
There was a problem hiding this comment.
Yes good ideas
But for the struct, I'm using a GetOrCreateFeature() that is waiting for a class, then for the tuple, because we can pass a factory I also tried a Tuple.Create<UpdateDelegate, AfterUpdateDelegate>(null, null)), but then we can't do delegates.Item1 += () => updateAsync() as it is readonly.
sebastienros
approved these changes
Nov 11, 2021
This was referenced Oct 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10672
Related to
IVolatileDocumentManager.UpdateAtomicAsync()that for now is never used in OC.One problem since we made
IVolatileDocumentManagera singleton is that the same delegate list is always used / executed and grow up, so the delegate list should be still held at the scope level which I forgot to do.The 2nd problem is when enlisting multiple delegates (not allowed with
UpdateAsync()), we can enlist multiple time the same delegate (targetting the same method and so on), not a problem most of the time but not good when we do things by batches where the same one can be added many times, so the delegate list should only contain distinct delegates.