Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MailKit, MimeKit 3.0 #10863

Merged
merged 1 commit into from
Jan 8, 2022
Merged

MailKit, MimeKit 3.0 #10863

merged 1 commit into from
Jan 8, 2022

Conversation

@hishamco
Copy link
Member

Is there any features or / and breaking-changes list?

@agriffard
Copy link
Member Author

https://github.com/jstedfast/MailKit/blob/master/ReleaseNotes.md
https://github.com/jstedfast/MimeKit/blob/master/ReleaseNotes.md

Removed APIs marked as [Obsolete] in 2.x.

But we don't seem to use those obsolete methods.

@hishamco
Copy link
Member

jstedfast/MailKit#1161
jstedfast/MimeKit#705

Please hold this I need to check them ..

@hishamco
Copy link
Member

Regarding this change jstedfast/MailKit@e32bb65#diff-7bc7f11950f4b02de31df29546c0196e918c447abf653e9550776fd21e32b75aR78 can we return the response result into SmtpResult

/cc @sebastienros

@sebastienros
Copy link
Member

If it's not fixing anything critical in OC I'd prefer to wait for after 1.2 to limit the risk of breaking anything (so close to shipping).

@hishamco
Copy link
Member

Nothing to break according to thier changes. BTW I create a PR #10892, to add a server response that added by MailKit, this is useful if someone want to know the actual server response

@agriffard agriffard merged commit f8df941 into main Jan 8, 2022
@agriffard agriffard deleted the ag/MimeKit3.0 branch January 8, 2022 17:03
@hishamco
Copy link
Member

hishamco commented Jan 8, 2022

I think it's a time to look into #10892 if the upcoming version will be 2.0.0 I will change the PR because I may introduce a breaking changes

1 similar comment
@hishamco

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants