Allow sending email without "To" if "Cc" or "Bcc" is provided #10853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamco
commented
Dec 10, 2021
|
I may need to check work flow task too, to react to this change |
|
@Skrypt did I miss anything? |
|
Yes, here. Remove required. |
Skrypt
reviewed
Dec 12, 2021
| var mimeMessage = FromMailMessage(message); | ||
|
|
||
| if (mimeMessage.From.Count == 0 && mimeMessage.Cc.Count == 0 && mimeMessage.Bcc.Count == 0) | ||
| { | ||
| return SmtpResult.Failed(S["The mail message should have at least one of these headers: To, Cc or Bcc."]); |
There was a problem hiding this comment.
I'm asking myself if the Mailkit library now won't return proper error messages when we update it to the latest version like you saw here #10863
I would tend to let the message fail without throwing a specific error message here. Let the library do its work if that's possible.
There was a problem hiding this comment.
I think there's no throwing here, I suggest to log an explicit message to make it clear. I'm not sure if the server reponse returns a specific or general message
Let's accept this as its, then we can add the server response to SmtpResult as I suggested in related link
test/OrchardCore.Tests/Modules/OrchardCore.Email/Workflows/EmailTaskTests.cs
Outdated
Show resolved
Hide resolved
test/OrchardCore.Tests/Modules/OrchardCore.Email/Workflows/EmailTaskTests.cs
Outdated
Show resolved
Hide resolved
Skrypt
approved these changes
Dec 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #10840