Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Fluid 2.2.10 #10971

Merged
merged 11 commits into from
Jan 7, 2022
Merged

Upgrade to Fluid 2.2.10 #10971

merged 11 commits into from
Jan 7, 2022

Conversation

hishamco
Copy link
Member

@hishamco hishamco commented Jan 6, 2022

@agriffard
Copy link
Member

I started the same on #10970 but I can close it.
Same error on DateTimeParser.

@hishamco
Copy link
Member Author

hishamco commented Jan 6, 2022

I just saw your PR now, if you need me look to DateTimeParser I will do

@agriffard agriffard mentioned this pull request Jan 6, 2022
Closed
@agriffard
Copy link
Member

I just saw your PR now, if you need me look to DateTimeParser I will do

Yes, please.

@sebastienros
Copy link
Member

Bug in Parlot, will fix.

@sebastienros sebastienros enabled auto-merge (squash) January 7, 2022 00:16
@Skrypt Skrypt changed the title Upgrade to Fluid 2.2.9 Upgrade to Fluid 2.2.10 Jan 7, 2022
@sebastienros
Copy link
Member

@deanmarcussen I could use a failing unit test in Parlot, definitely one more bug I introduced in OneOf but haven't looked at the DateTimeParser in detail.

@deanmarcussen
Copy link
Member

@deanmarcussen I could use a failing unit test in Parlot, definitely one more bug I introduced in OneOf but haven't looked at the DateTimeParser in detail.

Yeah you broke it :(
I'll see why

@hishamco
Copy link
Member Author

hishamco commented Jan 7, 2022

I remembered Seb said the bug in Parlot. If it's in DateTimeParser I will have a look as I said yesterday, unless Dean intrested ;)

@sebastienros
Copy link
Member

I think I am going to reference Parlot's source code directly instead of doing this release dance :/

@sebastienros
Copy link
Member

Or maybe it's shortcodes that needs to be updated too

@deanmarcussen
Copy link
Member

YesSql.Filters has a reference too…

@sebastienros sebastienros merged commit 4a3902f into main Jan 7, 2022
@sebastienros sebastienros deleted the hishamco/fluid branch January 7, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agriffard agriffard Awaiting requested review from agriffard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hishamco @agriffard @sebastienros @deanmarcussen