Fix prop-* type in BaseShapeTagHelper

[hishamco]

Fixes #5090

[hishamco]

@agriffard this is a straightforward fix, hope you merge ASAP

[sebastienros]

Please don't merge, I'll explain later

[giannik]

explanation here : https://www.youtube.com/watch?v=G5qPmYmLaGY&t=1392s

…

On Fri, Dec 20, 2019 at 8:29 PM Sébastien Ros ***@***.***> wrote: Please don't merge, I'll explain later — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#5094?email_source=notifications&email_token=AALSLNPSUZANDKILKPJRE23QZUFG3A5CNFSM4J6ADFF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHNYZIQ#issuecomment-568036514>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALSLNKWAGUVI7AETRCGP7LQZUFG3ANCNFSM4J6ADFFQ> .

[hishamco]

Please don't merge, I'll explain later

I label the PR with dontmerge, waiting for your explanation

[jtkech]

Hmm, this let me think that in Liquid i think we don't support yet DictionaryAttributePrefix.

For infos here _properties was never used, in one of my PR i just removed it.

[hishamco]

Hmm, this let me think that in Liquid i think we don't support yet DictionaryAttributePrefix.

I see, I don't know about this one

[sebastienros]

If _properties is not used, and removing it doesn't break prop-foo then remove it.
If you think you change is fixing something, I'd like to know what you have tested and how it fixed the issue.

[jtkech]

Yes, i tested it _properties is useless

And i have to look if DictionaryAttributePrefix is implemented in Liquid

[hishamco]

Yes, i tested it _properties is useless

It's useless before the PR

If you think you change is fixing something, I'd like to know what you have tested and how it fixed the issue.

I'm just asking why the dictionary accepts Object before? I think the pattern similar to what ASP.NET Core has 'asp-route-*`

[ns8482e]

i think we don't support yet DictionaryAttributePrefix.

@jtkech for info, I managed to add support for it while working on #4955 (still WIP), so that I could write asp-route-returnUrl in admin liquid template.

[jtkech]

@ns8482e cool 👍 you will have to share the code ;)

[ns8482e]

you will have to share the code ;)

Sure! Let me create separate PR for that so that it can be independently merged and don't have to wait for #4955