Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce allocations in CamelFriendly #9994

Merged
merged 2 commits into from
Jul 30, 2021
Merged

Reduce allocations in CamelFriendly #9994

merged 2 commits into from
Jul 30, 2021

Conversation

lahma
Copy link
Contributor

@lahma lahma commented Jul 29, 2021 •
edited
Loading

  • Tested with agency and blog theme
  • Using ZString instead of new StringBuilder
  • Using "normal algorithm" which start from beginning and no need to shuffle data in array (insert vs append)
  • Rider was complaining about duplicate reference OrchardCore.Data.Abstraction in OrchardCore.Alias.csproj so fixed that too

@agriffard agriffard merged commit 84e8afb into OrchardCMS:main Jul 30, 2021
@lahma lahma deleted the reduce-allocationsin-camel-friendly branch July 30, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienros sebastienros sebastienros left review comments

@deanmarcussen deanmarcussen deanmarcussen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lahma @sebastienros @deanmarcussen @agriffard