Skip to content

Commit

Permalink
Removing length limitation from IHostnameBinding.Aliases property
Browse files Browse the repository at this point in the history
  • Loading branch information
@napernik
napernik committed Jul 16, 2019
1 parent b6bed91 commit c8787b3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Composite/Data/Types/IHostnameBinding.cs
View file
Expand Up @@ -48,7 +48,7 @@ public interface IHostnameBinding : IData
string PageNotFoundUrl { get; set; } string PageNotFoundUrl { get; set; }


/// <exclude /> /// <exclude />
[StoreFieldType(PhysicalStoreFieldType.String, 512, IsNullable = true)] [StoreFieldType(PhysicalStoreFieldType.LargeString)]
[ImmutableFieldId("{80C298F2-F493-465D-9F28-4F50DD0C03D5}")] [ImmutableFieldId("{80C298F2-F493-465D-9F28-4F50DD0C03D5}")]
string Aliases { get; set; } string Aliases { get; set; }


Expand Down

2 comments on commit c8787b3

@burningice2866
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't removing nullable problematic for existing IHostnameBinding records on SQL Server which risk failing while converting the column to not allow for null values?

@napernik
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed with a new commit.

Please sign in to comment.