Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chrome] Input fields loosing focus if login/password information is preserved in browser #504

Closed
napernik opened this issue Dec 18, 2017 · 4 comments
Assignees

Comments

@napernik
Copy link
Member

napernik commented Dec 18, 2017

Repro:

  1. Use Chrome version 63.x
  2. Log into C1 console, choose to remember the login/password information
  3. Click on "Add page" in с1 console, or edit any C1 page
  4. Try editing one of the fields

Result: the field loses focus every 5 seconds, making editing inputs rather difficult.

Workaround is either to remove remembered password in Chrome or to use the incognito mode.

@napernik napernik added the bug label Dec 18, 2017
@napernik napernik changed the title [Chrome] Input fields loosing focus [Chrome] Input fields loosing focus if login/password information is preserved in browser Dec 18, 2017
neexite added a commit that referenced this issue Dec 19, 2017
@neexite neexite reopened this Dec 19, 2017
@neexite neexite closed this as completed Dec 20, 2017
@neexite
Copy link
Member

neexite commented Dec 20, 2017

Customers with a C1 CMS Service Plan (developer, business or premium) can now install a hotfix that solve this issue.

Install steps for hotfix:

  1. Launch the CMS Console
  2. On the System perspective, browse down Packages, Available Packages, Composite.Updates
  3. Install the package Composite.Updates.HotFix504

The hotfix require browser cache to be flushed - for browsers accessing the CMS console to edit content, use the browsers cache flush option (ctrl+shift+del - "Clear cache" / "Clear cached files" depending on browser).

@neexite
Copy link
Member

neexite commented Dec 20, 2017

Manual fix for this issue:

  1. Open for edit ~/Composite/scripts/compressed/top.js
  2. Add the following line to the end of the file:

"undefined"!=typeof KickStart&&"undefined"!=typeof EventBroadcaster&&EventBroadcaster.subscribe&&/Chrome/.test(navigator.userAgent)&&(KickStart.subscribeToRemoveObsoluteDecks=function(){this.isSubscribedToRemoveObsoluteDecks||(this.isSubscribedToRemoveObsoluteDecks=!0,EventBroadcaster.subscribe(BroadcastMessages.APPLICATION_LOGIN,{handleBroadcast:function(){try{if("undefined"!=typeof top&&top.bindingMap&&"undefined"!=typeof DocumentManager&&DocumentManager.detachBindings)for(var e=["logindeck","changepassworddeck"],t=0;t<e.length;t++)obsoletedDeckName=e[t],top.bindingMap[obsoletedDeckName]&&(obsoletedDeck=top.bindingMap[obsoletedDeckName],obsoletedDeck&&obsoletedDeck.bindingElement&&(DocumentManager.detachBindings(obsoletedDeck.bindingElement,!0),obsoletedDeck.bindingElement.innerHTML=""))}catch(e){}}}))},KickStart.subscribeToRemoveObsoluteDecks());

@burningice2866
Copy link
Contributor

burningice2866 commented Jan 4, 2018

Since a new commit has been made regarding this issue, is the fix mentioned by @neexite still complete?

@napernik
Copy link
Member Author

napernik commented Jan 4, 2018

Yes, the other commit is fixing the Nightwatch tests that we're using, which are not a part of deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants