Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#181) Add missing string concatenation for native methods #182

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

AFaust
Copy link
Contributor

@AFaust AFaust commented Apr 2, 2021

CHECKLIST

We will not consider a PR until the following items are checked off--thank you!

  • There aren't existing pull requests attempting to address the issue mentioned here
  • Submission developed in a feature branch--not master

CONVINCING DESCRIPTION

This PR fixes a bug with the thread dump-based tools which cut off stack traces at the highest level native method in the stack, just because a string concatenation was missing when handling native methods.

RELATED INFORMATION

Fixes #181

@AFaust AFaust added this to the 1.2.0.0 milestone Apr 2, 2021
Copy link
Contributor

@binduwavell binduwavell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated the issue prior to the PR and that the PR does resolve the issue.

@binduwavell binduwavell merged commit 02937c3 into OrderOfTheBee:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thread Dump: stack trace cut off at native methods
2 participants