Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextField: introduce new size #126

Closed
panvourtsis opened this issue Dec 2, 2020 · 1 comment · Fixed by #138
Closed

TextField: introduce new size #126

panvourtsis opened this issue Dec 2, 2020 · 1 comment · Fixed by #138
Assignees
Labels
enhancement New feature or request v5 This feature will be released on version 5 (next)

Comments

@panvourtsis
Copy link
Collaborator

panvourtsis commented Dec 2, 2020

Description

We will introduce the new size of the TextField Component. This new size will update the logic of padding that we currently have.

Based on #55

Design

You can find the designs here
Specifically the new size is at the lower end of that screen

image

case of colored TextField
image

Implementation

You will update the current component

  • Add a new prop size which will take two options md | sm
    • normal will be the default
    • padding are different for each size
  • check and update the previous padding logic with icons based on the design
  • change color based on what is passed
  • remove type from input e.g no primary etc

Testing

  • Check that the size updates the component accordingly
@panvourtsis panvourtsis added the enhancement New feature or request label Dec 2, 2020
This was referenced Dec 2, 2020
@michalisKout michalisKout self-assigned this Dec 3, 2020
@github-actions
Copy link

🎉 This issue has been resolved in version 1.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the v5 This feature will be released on version 5 (next) label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v5 This feature will be released on version 5 (next)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants