Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable FXS harvesting #1954

Merged
merged 8 commits into from
Dec 6, 2023
Merged

Enable FXS harvesting #1954

merged 8 commits into from
Dec 6, 2023

Conversation

sparrowDom
Copy link
Member

  • add a PriceFeedPair contract that is able to combine 2 chainlink price feeds.
  • add that price feed to OETH Oracle
  • configure harvester to support harvesting of FXS token

@notion-workspace Notion Workspace
Copy link

Add FXS to Harvester

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against 3d4d991

@codecov Codecov
Copy link

codecov bot commented Dec 5, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d8d635e) 73.99% compared to head (a5d2872) 73.95%.
Report is 2 commits behind head on nicka/convex-frax-locking.

❗ Current head a5d2872 differs from pull request most recent head 3d4d991. Consider uploading reports for the commit 3d4d991 to get more accurate results

Files Patch % Lines
contracts/contracts/oracle/PriceFeedPair.sol 88.46% 3 Missing ⚠️
Additional details and impacted files 
@@                      Coverage Diff                      @@
##           nicka/convex-frax-locking    #1954      +/-   ##
=============================================================
- Coverage                      73.99%   73.95%   -0.04%     
=============================================================
  Files                             60       61       +1     
  Lines                           2969     2999      +30     
  Branches                         770      775       +5     
=============================================================
+ Hits                            2197     2218      +21     
- Misses                           769      778       +9     
  Partials                           3        3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

naddison36
naddison36 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@naddison36 naddison36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.,

I've raised PR #1955 with documentation updates

sparrowDom and others added 3 commits December 6, 2023 10:26
@sparrowDom
remove not needed file
0ebbfa3
@naddison36
FXS Harvest documentation update (#1955)
eb14f71 
* Fix js linter

* Added CRV, CVX, BAL and Aura prices to OETH Oracle contract dependencies

* Added link from Harvester to Oracle Router

* Added FXS/ETH feed to Oracle contract diagram

* Update Natspec of PriceFeedPair
@naddison36
Fix linter
3d4d991
@naddison36 naddison36 merged commit 6353dd8 into nicka/convex-frax-locking Dec 6, 2023
15 checks passed
@naddison36 naddison36 deleted the sparrowDom/fxsHarvest branch December 6, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahthepro shahthepro shahthepro left review comments

@naddison36 naddison36 naddison36 approved these changes

@DanielVF DanielVF Awaiting requested review from DanielVF DanielVF is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sparrowDom @naddison36 @shahthepro