Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send all triple stopres implementetion to telemetry #2879

Merged

Conversation

Mihajlo-Pavlovic
Copy link
Collaborator

@Mihajlo-Pavlovic Mihajlo-Pavlovic commented Jan 12, 2024

Description

With this code we will send all enabled triple-store implementations to signaling server

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

const nodeData = {
version: pjson.version,
identity: this.networkModuleManager.getPeerId().toB58String(),
hostname: this.config.hostname,
triple_store: this.config.modules.tripleStore.defaultImplementation,
triple_stores: tripleStoreImplementations,
Copy link
Contributor

@djordjekovac djordjekovac Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's send triple store info the same way we are sending blockchain, as object and field: {"name" : ' '}

@NZT48 NZT48 merged commit efffab8 into v6/develop Jan 12, 2024
3 checks passed
@NZT48 NZT48 added the improvement Improvements or enhancements to existing features label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements or enhancements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants