Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test scheduling - stack dive #31

Open
lmagyar opened this issue Jan 24, 2016 · 0 comments
Open

Test scheduling - stack dive #31

lmagyar opened this issue Jan 24, 2016 · 0 comments

Comments

@lmagyar
Copy link
Member

lmagyar commented Jan 24, 2016

We should check to not make stack dives!!!
TaskCompletionSource-s for operations are created without TaskCreationOptions.RunContinuationsAsynchronously, and nearly all ContinueWith uses TaskContinuationOptions.ExecuteSynchronously.
When we go from sync OnNotifyUnhandledException and OnNotifyPaused to TAP async equivalents, there are two await Task.Yield(), these should break most of the loops.
NOTE: SendResponse's TaskCompletionSource.Task should continue ASAP, and not wait for the other activities in the WF, this way WF can run on the tail of the operations!
See eg.: http://stackoverflow.com/questions/28321457/taskcontinuationoptions-runcontinuationsasynchronously-and-stack-dives

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant