Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master]: Changing XmlExtentions.GetElements() to skip unexpected Xml… #77

Closed
wants to merge 1 commit into from
Closed

Conversation

blackboxlogic
Copy link
Contributor

Changing XmlExtentions.GetElements() to skip unexpected XmlElements instead of just stopping.

Adding test call for Osm.ReadXml() using a sample response from OverpassApi, which includes unexpected XmlElements.

My attempt at fixing #76

…Elements instead of just stopping.

Adding test call for Osm.ReadXml() using a sample response from OverpassApi, which includes unexpected XmlElements.
@blackboxlogic blackboxlogic mentioned this pull request Jul 28, 2019
@blackboxlogic blackboxlogic marked this pull request as ready for review July 28, 2019 16:26
@xivk xivk self-requested a review July 29, 2019 11:50
@xivk xivk self-assigned this Jul 29, 2019
@xivk
Copy link
Contributor

xivk commented Jul 29, 2019

This was merged in the develop branch. Master is the latest stable.

I will change the default branch to develop just to make sure this doesn't happen again.

Thanks for this excellent pull-request! 💯

@xivk xivk closed this Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants