Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to download files when using the discography option. #26

Closed
ghost opened this issue Apr 3, 2017 · 6 comments
Closed

Failing to download files when using the discography option. #26

ghost opened this issue Apr 3, 2017 · 6 comments
Labels
help A call for help

Comments

@ghost
Copy link

ghost commented Apr 3, 2017

image

Works fine when downloading albums however I get this error when downloading discographys. Here's the link I'm am using to download. https://newretrowave.bandcamp.com/

@zontargs
Copy link

zontargs commented Apr 5, 2017

I've also seen this problem. It doesn't only happen when using the discography option, but also if you queue up too many albums, or even one very long album.

Bandcamp throttles you by refusing connections if you attempt to access too many files over too short of a time. The size checks + download attempts can quickly exceed this limit if you're attempting to work with >100 files at a time.

EDIT: just had it happen after doing a size check on 40 files, then downloading about 30 of them.

An option to skip the size estimate and limit the number of parallel connections (3-5 seems sustainable based on experience with batched wget downloads from Bandcamp) for large operations would be appreciated.

@Otiel
Copy link
Owner

Otiel commented Apr 7, 2017

I suggest you try using the exponential back-off algorithm that has already been implemented. Can you try adding these lines to your settings file (BcDlSettings.json)?

"DownloadMaxTries": 7
"DownloadRetryCooldown": 0.2
"DownloadRetryExponential": 4.0

Check the wiki for more info.

It should work as shown below:

screenshot

Let me know if that helps.

@Otiel Otiel added the help A call for help label Apr 7, 2017
@zontargs
Copy link

zontargs commented Apr 8, 2017

Thanks. I've enabled that setting, and it was a moderate improvement. Without "download one album at a time" enabled, the download failures tend to clump together, resulting in simultaneous retries tripping the spam detector, continuing the cycle. It appears to be less of an issue when doing one album at a time.

@Otiel
Copy link
Owner

Otiel commented Apr 10, 2017

By "tripping the spam detector", you mean there are several failures, but before the max retry count (7), each song is correctly downloaded right?

@zontargs
Copy link

zontargs commented Apr 11, 2017

Negative. Because many of the 7th attempts happen nearly simultaneously, a large number of those will fail in a large project. I attempted to download a 284 file album, with 69 files failing to download on the 7th attempt.

Also of note: even an hour after the last download was attempted, the operation had not terminated. The program simply sat there after the last download attempt, without completing and printing a summary:
http://i.thinimg.com/img/cux.png

While the exponential back-off improves speed on smaller projects, an option to limit the number of simultaneous connection attempts would be better for large projects. What works for a sprint does not work well for a marathon.

@Otiel
Copy link
Owner

Otiel commented Apr 13, 2017

Ok, I'll work on adding such an option when I find the time. Thanks for your tests and suggestions.

@Otiel Otiel closed this as completed Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help A call for help
Projects
None yet
Development

No branches or pull requests

2 participants