Fix regridding nb to pass jenkins #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… get replaced, as with WFS_example.ipynb geoserver data is currently not replicated anywhere, everything is on the host boreas.ouranos.ca. Also did a full re-run of the notebook.
…endering xarray html code seems to change on every run, breaking Jenkins.
This the following error: ``` 21:41:59 _ pavics-sdi-fix-regridding-nb-to-pass-jenkins/docs/source/notebooks/rendering.ipynb::Cell 2 _ 21:41:59 Notebook cell execution failed 21:41:59 Cell 2: Cell outputs differ 21:41:59 21:41:59 Input: 21:41:59 wms.contents["tasmax"].styles.keys() 21:41:59 21:41:59 Traceback: 21:41:59 mismatch 'text/plain' 21:41:59 21:41:59 assert reference_output == test_output failed: 21:41:59 21:41:59 "dict_keys(['...ill/ferret'])" == "dict_keys(['...oxfill/alg'])" 21:41:59 Skipping 165 identical leading characters in diff, use -v to show 21:41:59 - 'boxfill/ferret', 'boxfill/alg']) 21:41:59 + 'boxfill/alg', 'boxfill/ferret']) ```
tlvu
added a commit
to Ouranosinc/PAVICS-e2e-workflow-tests
that referenced
this pull request
Mar 16, 2021
…or-pavics-sdi-regridding-notebook Update nbval sanitize config for pavics sdi regridding notebook For this regridding notebook https://github.com/Ouranosinc/pavics-sdi/blob/bbe3061dceb98688e9fd58836fbc50992ee31568/docs/source/notebooks/regridding.ipynb (PR Ouranosinc/pavics-sdi#201) to pass Jenkins. Double Jenkins run to be sure: http://jenkins.ouranos.ca/job/PAVICS-e2e-workflow-tests/job/update-nbval-sanitize-config-for-pavics-sdi-regridding-notebook/7/console http://jenkins.ouranos.ca/job/PAVICS-e2e-workflow-tests/job/update-nbval-sanitize-config-for-pavics-sdi-regridding-notebook/8/console Jenkins passing also required bird-house/birdhouse-deploy#132 and Ouranosinc/pavics-sdi#206
|
Notebook diff: https://app.reviewnb.com/Ouranosinc/pavics-sdi/pull/206/ |
Full-run recorded as well.
huard
approved these changes
Mar 16, 2021
tlvu
added a commit
to bird-house/birdhouse-deploy
that referenced
this pull request
Mar 16, 2021
finch: update to 0.7.0 Require PR #131 for extra testdata for the new regridding notebook. Regridding notebook will also need to be adjusted for some output to pass Jenkins test suite, PR Ouranosinc/pavics-sdi#206. Nbval escape regex also needed for the regridding notebook, PR Ouranosinc/PAVICS-e2e-workflow-tests#63 See Finch changelog in PR bird-house/finch#158 Passing Jenkins build http://jenkins.ouranos.ca/job/PAVICS-e2e-workflow-tests/job/update-nbval-sanitize-config-for-pavics-sdi-regridding-notebook/10/console
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires Ouranosinc/PAVICS-e2e-workflow-tests#63 and bird-house/birdhouse-deploy#132 to have passing Jenkins.
Passing Jenkins: http://jenkins.ouranos.ca/job/PAVICS-e2e-workflow-tests/job/update-nbval-sanitize-config-for-pavics-sdi-regridding-notebook/10/console
See commits for list of what has been done.