Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap-testdata: new testdata for pavics-sdi regridding notebook #131

Merged
merged 1 commit into from Mar 15, 2021

Conversation

tlvu
Copy link
Collaborator

@tlvu tlvu commented Mar 15, 2021

Need those new testdata on hosts other than pavics.ouranos.ca to run Jenkins end-to-end test suite against those hosts.

For notebook https://github.com/Ouranosinc/pavics-sdi/blob/bbe3061dceb98688e9fd58836fbc50992ee31568/docs/source/notebooks/regridding.ipynb

See PR Ouranosinc/pavics-sdi#201

@tlvu
Copy link
Collaborator Author

tlvu commented Mar 15, 2021

@huard 2 of those new files are outside of the testdata/ folder, are we okay with that?

In the past, we already have files outside of the testdata/ folder. Do we need more enforcement going forward or it's okay to use files outside of the testdata/ folder as long as there are noting suitable in the testdata/ folder?

@tlvu tlvu mentioned this pull request Mar 15, 2021
@huard
Copy link
Collaborator

huard commented Mar 15, 2021

Good question. I don't feel like I'm able to give you a good answer though. I suggest we hot-fix this for now but come back to this question during our next meeting.

@tlvu tlvu merged commit bf5f31d into master Mar 15, 2021
@tlvu tlvu deleted the add-new-testdata-for-pavics-sdi-regridding-notebook branch March 15, 2021 23:32
@tlvu
Copy link
Collaborator Author

tlvu commented Mar 16, 2021

Also for #132

tlvu added a commit that referenced this pull request Mar 16, 2021
finch: update to 0.7.0

Require PR #131 for extra testdata for the new regridding notebook.

Regridding notebook will also need to be adjusted for some output to pass Jenkins test suite, PR Ouranosinc/pavics-sdi#206.

Nbval escape regex also needed for the regridding notebook, PR Ouranosinc/PAVICS-e2e-workflow-tests#63

See Finch changelog in PR bird-house/finch#158

Passing Jenkins build http://jenkins.ouranos.ca/job/PAVICS-e2e-workflow-tests/job/update-nbval-sanitize-config-for-pavics-sdi-regridding-notebook/10/console
ChaamC added a commit that referenced this pull request Nov 30, 2023
## Changes
- New optional-component `test-cowbird-jupyter-access` that executes a
script to set up a test user along with different
  test files. This component is used for the related e2e test from the 

[PAVICS-e2e-workflow-tests](https://github.com/Ouranosinc/PAVICS-e2e-workflow-tests)
repo.

## Fixes
- Updates incorrect WPS outputs resource name in the cowbird config.

## Additional Information

- Related to PR on `PAVICS-e2e-workflow-tests` :
[#131](Ouranosinc/PAVICS-e2e-workflow-tests#131)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants