Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.7.0 #158

Merged
merged 6 commits into from Mar 15, 2021
Merged

Release 0.7.0 #158

merged 6 commits into from Mar 15, 2021

Conversation

huard
Copy link
Collaborator

@huard huard commented Mar 15, 2021

Overview

This PR updates the CHANGES and bumps version to 0.7.0

@huard huard requested a review from tlvu March 15, 2021 13:26
@huard
Copy link
Collaborator Author

huard commented Mar 15, 2021

@tlvu There doesn't seem to be a notebook environment.yml file to indicate dependencies.

@tlvu
Copy link
Collaborator

tlvu commented Mar 15, 2021

@tlvu There doesn't seem to be a notebook environment.yml file to indicate dependencies.

Should be from the same "dev" env for the bird.

@tlvu
Copy link
Collaborator

tlvu commented Mar 15, 2021

@tlvu There doesn't seem to be a notebook environment.yml file to indicate dependencies.

Should be from the same "dev" env for the bird.

Indeed, same "dev" env since it assume a running local Finch see

WPS_URL = http://localhost:5000
and

finch/Makefile

Line 139 in babd6fa

@bash -c 'for nb in $(CURDIR)/docs/source/notebooks/*.ipynb; do WPS_URL="$(WPS_URL)" jupyter nbconvert --to notebook --execute --ExecutePreprocessor.timeout=60 --output "$$nb" "$$nb"; sed -i "s@$(WPS_URL)/outputs/@$(OUTPUT_URL)/@g" "$$nb"; done; cd $(APP_ROOT)'

Copy link
Collaborator

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine, except the lax part and refresh-notebooks.

Makefile Outdated Show resolved Hide resolved
docs/source/notebooks/finch-usage.ipynb Outdated Show resolved Hide resolved
@huard
Copy link
Collaborator Author

huard commented Mar 15, 2021

@tlvu ok comme ça ?

Copy link
Collaborator

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, good for me. If you have not tried a make test-notebooks after your make refresh-notebooks try it and make sure it passes.

docs/source/notebooks/dap_subset.ipynb Show resolved Hide resolved
docs/source/notebooks/dap_subset.ipynb Show resolved Hide resolved
@huard huard merged commit 1c3566b into master Mar 15, 2021
@huard huard deleted the release_0.7.0 branch March 15, 2021 17:43
tlvu added a commit to bird-house/birdhouse-deploy that referenced this pull request Mar 15, 2021
tlvu added a commit to bird-house/birdhouse-deploy that referenced this pull request Mar 16, 2021
finch: update to 0.7.0

Require PR #131 for extra testdata for the new regridding notebook.

Regridding notebook will also need to be adjusted for some output to pass Jenkins test suite, PR Ouranosinc/pavics-sdi#206.

Nbval escape regex also needed for the regridding notebook, PR Ouranosinc/PAVICS-e2e-workflow-tests#63

See Finch changelog in PR bird-house/finch#158

Passing Jenkins build http://jenkins.ouranos.ca/job/PAVICS-e2e-workflow-tests/job/update-nbval-sanitize-config-for-pavics-sdi-regridding-notebook/10/console
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants