update nb for wpsoutputs path change to bird name #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See PR bird-house/birdhouse-deploy#203 Jenkins failure due to wpsoutputs path change: ``` ___ pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb::Cell 23 ___ Notebook cell execution failed Cell 23: Cell outputs differ Input: from urllib.parse import urlparse output_url = result.get().output print("output_url = ", output_url) parsed = urlparse(output_url) output_path = parsed.path.replace("wpsoutputs", "wps_outputs") print("output_path = ", output_path) output_thredds_url = ( f"https://{parsed.hostname}/twitcher/ows/proxy/thredds/dodsC/birdhouse{output_path}" ) print("output_thredds_url = ", output_thredds_url) Traceback: mismatch 'stdout' assert reference_output == test_output failed: 'output_url =...FILE/out.nc\n' == 'output_url =...FILE/out.nc\n' - output_url = https://WPS_HOST/wpsoutputs/finch/STATUS_FILE/out.nc ? ------ + output_url = https://WPS_HOST/wpsoutputs/STATUS_FILE/out.nc - output_path = /wps_outputs/finch/STATUS_FILE/out.nc ? ------ + output_path = /wps_outputs/STATUS_FILE/out.nc - output_thredds_url = https://PAVICS_FQDN/twitcher/ows/proxy/thredds/dodsC/birdhouse/wps_outputs/finch/STATUS_FILE/out.nc ? ------ + output_thredds_url = https://PAVICS_FQDN/twitcher/ows/proxy/thredds/dodsC/birdhouse/wps_outputs/STATUS_FILE/out.nc _______ pavics-sdi-master/docs/source/notebooks/subsetting.ipynb::Cell 4 _______ Notebook cell execution failed Cell 4: Cell outputs differ Input: res = resp.get() print("URL: ", res.output) res = resp.get(asobj=True) res.output Traceback: mismatch 'stdout' assert reference_output == test_output failed: 'URL: https:..._Africa.nc.\n' == 'URL: https:..._Africa.nc.\n' - URL: https://WPS_HOST/wpsoutputs/flyingpigeon/STATUS_FILE/tasmax_Amon_MPI-ESM-MR_rcp45_r1i1p1_200601-200612_Africa.nc ? ------------- + URL: https://WPS_HOST/wpsoutputs/STATUS_FILE/tasmax_Amon_MPI-ESM-MR_rcp45_r1i1p1_200601-200612_Africa.nc Downloading to /tmp/tmpRANDOM/tasmax_Amon_MPI-ESM-MR_rcp45_r1i1p1_200601-200612_Africa.nc. ```
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
|
Nice!
|
fmigneault
reviewed
Feb 16, 2023
| @@ -90,7 +90,7 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #1. ds.heat_wave_frequency.plot()
I'm assuming the changing memory address is not picked up by the output diff during E2E tests?
Reply via ReviewNB
There was a problem hiding this comment.
We have a regex to ignore those memory address change.
fmigneault
approved these changes
Feb 16, 2023
tlvu
added a commit
to bird-house/birdhouse-deploy
that referenced
this pull request
Feb 17, 2023
Before this fix, finch, raven, flyingpigeon were dumping their output directly under `https://PAVICS_HOST/wpsoutputs/`. With this fix, it will be under each bird name, ex: `https://PAVICS_HOST/wpsoutputs/finch/` which is cleaner and follows what malleefowl and hummingbird already does. Fixes #11. Fixes https://crim-ca.atlassian.net/browse/DAC-398 Requires PR Ouranosinc/pavics-sdi#280, bird-house/finch#273, Ouranosinc/raven#459 If `optional-components/secure-data-proxy` is enabled, might need some additional permissions for each bird in https://github.com/bird-house/birdhouse-deploy/blob/master/birdhouse/optional-components/secure-data-proxy/config/magpie/config.yml.template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PR bird-house/birdhouse-deploy#203
Jenkins failure due to wpsoutputs path change: