update nb for wpsoutputs path change to bird name #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See PR bird-house/birdhouse-deploy#203 Makefile updated for future refresh as well. Jenkins failure due to wpsoutputs path change: ``` _________ finch-master/docs/source/notebooks/finch-usage.ipynb::Cell 3 _________ Notebook cell execution failed Cell 3: Cell outputs differ Input: print("Process status: ", resp.status) urls = resp.get() print("Link to process output: ", urls.output) Traceback: mismatch 'stdout' assert reference_output == test_output failed: 'Process stat...20650101.nc\n' == 'Process stat...20650101.nc\n' Skipping 77 identical leading characters in diff, use -v to show - psoutputs/finch/STATUS_FILE/frost_days_sres_a2_experiment_20460101_20650101.nc ? ------ + psoutputs/STATUS_FILE/frost_days_sres_a2_experiment_20460101_20650101.nc ```
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
fmigneault
approved these changes
Feb 16, 2023
huard
approved these changes
Feb 16, 2023
tlvu
added a commit
to bird-house/birdhouse-deploy
that referenced
this pull request
Feb 17, 2023
Before this fix, finch, raven, flyingpigeon were dumping their output directly under `https://PAVICS_HOST/wpsoutputs/`. With this fix, it will be under each bird name, ex: `https://PAVICS_HOST/wpsoutputs/finch/` which is cleaner and follows what malleefowl and hummingbird already does. Fixes #11. Fixes https://crim-ca.atlassian.net/browse/DAC-398 Requires PR Ouranosinc/pavics-sdi#280, bird-house/finch#273, Ouranosinc/raven#459 If `optional-components/secure-data-proxy` is enabled, might need some additional permissions for each bird in https://github.com/bird-house/birdhouse-deploy/blob/master/birdhouse/optional-components/secure-data-proxy/config/magpie/config.yml.template.
|
Haha, I'm not sure how this went, but why was it merged with failing CI tests? |
Sorry, totally my bad. I did not think my change would break the CI so I thought it was existing problems. So the wps path was my fault but this one was existing: |
aulemahal
added a commit
to Ouranosinc/PAVICS-e2e-workflow-tests
that referenced
this pull request
Feb 22, 2023
Remove WPS name from output url for notebook testing This replaces bird-house/finch#273 as a solution for the change in output paths in wps outputs. The previous solution was breaking finch's CI. pyWPS wants "outputpath" and "outputurl" to match. This means that if "outputurl" has two levels, "outputpath" must have the same second level. But, when developing and testing (both locally and on the CI) "outputpath" is not explicitly set, thus is the default, thus does not match "outputurl"'s second level. The previous solution was patching the notebooks directly when generating them, but nothing of the sort was done in the test suite, which then failed. The proper way to fix this in the testing is this sanitizing file, thus I am suggesting to take care of the path issue here directly, and _only_ here. The related rollback in finch will be done in bird-house/finch#272.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PR bird-house/birdhouse-deploy#203
Makefileupdated for future refresh as well.Jenkins failure due to wpsoutputs path change: