Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile update for wpsoutputs path change to bird name #459

Merged
merged 1 commit into from Feb 17, 2023
Merged

Makefile update for wpsoutputs path change to bird name #459

merged 1 commit into from Feb 17, 2023

Conversation

tlvu
Copy link
Contributor

@tlvu tlvu commented Feb 16, 2023

Makefile updated for future refresh.

See PR bird-house/birdhouse-deploy#203

Not refreshing the notebooks because they do not all work in Jenkins yet and are not enabled in Jenkins by default.

@tlvu
Makefile update for wpsoutputs path change to bird name
d533910 
Makefile updated for future refresh.

See PR bird-house/birdhouse-deploy#203

Not refreshing the notebooks because they do not all work in Jenkins yet and
are not enabled in Jenkins by default.
@tlvu tlvu requested a review from fmigneault February 16, 2023 16:24
@tlvu tlvu mentioned this pull request Feb 16, 2023
Merged
@fmigneault
Copy link

Not refreshing the notebooks because they do not all work in Jenkins yet and are not enabled in Jenkins by default.

TEST_RAVEN_REPO=true and RAVEN_BRANCH=fix-for-wpsoutput-path-change should be provided in a manual test run along with RELATED_PR_NUMBER=203 to post results on bird-house/birdhouse-deploy#203

@tlvu
Copy link
Contributor Author

tlvu commented Feb 16, 2023

Not refreshing the notebooks because they do not all work in Jenkins yet and are not enabled in Jenkins by default.

TEST_RAVEN_REPO=true and RAVEN_BRANCH=fix-for-wpsoutput-path-change should be provided in a manual test run along with RELATED_PR_NUMBER=203 to post results on bird-house/birdhouse-deploy#203

Since we never got all Raven notebooks working properly under Jenkins, one more or less error is not a big deal. The next time someone refresh Raven notebooks for some reasons, this wpsoutputs path change will be part of it. If they use the Makefile to refresh, then the Makefile is ready.

tlvu added a commit to bird-house/birdhouse-deploy that referenced this pull request Feb 17, 2023
@tlvu
Fix birds not creating their wps output under each bird name (#203)
9fa669d 
Before this fix, finch, raven, flyingpigeon were dumping their output
directly under `https://PAVICS_HOST/wpsoutputs/`.

With this fix, it will be under each bird name, ex:
`https://PAVICS_HOST/wpsoutputs/finch/` which is cleaner and follows
what malleefowl and hummingbird already does.

Fixes #11.
Fixes https://crim-ca.atlassian.net/browse/DAC-398

Requires PR Ouranosinc/pavics-sdi#280,
bird-house/finch#273,
Ouranosinc/raven#459

If `optional-components/secure-data-proxy` is enabled, might need some
additional permissions for each bird in

https://github.com/bird-house/birdhouse-deploy/blob/master/birdhouse/optional-components/secure-data-proxy/config/magpie/config.yml.template.
@tlvu tlvu merged commit 36b63b6 into master Feb 17, 2023
@tlvu tlvu deleted the fix-for-wpsoutput-path-change branch February 17, 2023 03:12
Zeitsperre pushed a commit that referenced this pull request Aug 17, 2023
@tlvu
Makefile update for wpsoutputs path change to bird name (#459)
a9c0599 
Makefile updated for future refresh.

See PR bird-house/birdhouse-deploy#203

Not refreshing the notebooks because they do not all work in Jenkins yet
and are not enabled in Jenkins by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmigneault fmigneault fmigneault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tlvu @fmigneault