Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adress Yaroslav's comments on initial page layout #38

Closed
8 tasks done
mblomdahl opened this issue Apr 26, 2024 · 1 comment
Closed
8 tasks done

Adress Yaroslav's comments on initial page layout #38

mblomdahl opened this issue Apr 26, 2024 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@mblomdahl
Copy link
Collaborator

mblomdahl commented Apr 26, 2024 •
edited by mykhailodanilenko
Loading

Address PR #34 review comments from @Dykyi:

  • Have different views in a screens/ structure
  • Do not copy inline styling everywhere (share instead)
  • Make components more light-weight
  • Have shared types in a types/ color
  • Declare colors somewhere where they can be shared
  • Use "layouts" in the App.tsx
  • Add a utils/ for things like sizing functions
  • Use hooks for reusing
@mblomdahl mblomdahl added the help wanted Extra attention is needed label Apr 26, 2024
@mblomdahl mblomdahl mentioned this issue May 8, 2024
Closed
@ar9708
Copy link
Contributor

ar9708 commented Jun 6, 2024

Resolved in #51

@ar9708 ar9708 closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
Embeddable React Native Client
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mblomdahl @ar9708