Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Better Artists Credit #649

Closed
4 tasks done
ghost opened this issue Dec 21, 2023 · 4 comments
Closed
4 tasks done

A Better Artists Credit #649

ghost opened this issue Dec 21, 2023 · 4 comments
Assignees
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Dec 21, 2023

Description

Currently, Auxio force every artists to have a standardize name. The problem with this approach is that sometimes one artists could have multiple names in different language, styles, or sometimes even typo and that typo sometimes is intentional. Also an artists could colaborate with different artists.

1. [TRACK ARTISTS CREDIT]

1
Based on the image above, the artists credit of a track is "Hiroshi Okubo (nanosounds.jp) feat. SAK., TA-KO". Auxio currently split the artist with comma without any joint phrases, so there should be two artists because there are only one comma. But wait a minute, aren't there a joint phrases that would make it a 3 artists credit. Also the artists credit above is wrong because the actual artists credit is "Hiroshi Okubo feat. TA-KO".

This is the tag for this song.
MUSICBRAINZ_ARTISTID=41d3a5ee-f479-44fb-959b-e517ef2aa00e
MUSICBRAINZ_ARTISTID=97bbc527-8064-4bb4-9a38-2309285318c9
ARTIST=Hiroshi Okubo feat. TA-KO
ARTISTSORT=Okubo, Hiroshi feat. TA-KO
ARTISTS=Hiroshi Okubo
ARTISTS=TA-KO

This is the tag for another song.
MUSICBRAINZ_ARTISTID=41d3a5ee-f479-44fb-959b-e517ef2aa00e
MUSICBRAINZ_ARTISTID=8bd57bc9-666f-4da7-a7ad-1b6e7aeec8bd
ARTIST=Hiroshi Okubo (nanosounds.jp) feat. SAK.
ARTISTSORT=Okubo, Hiroshi (nanosounds.jp) feat. SAK.
ARTISTS=Hiroshi Okubo
ARTISTS=SAK.

As you can see, the both artists id is the same "MUSICBRAINZ_ARTISTID=41d3a5ee-f479-44fb-959b-e517ef2aa00e" for the artist "Hiroshi Okubo" but both song thankfully have the same "ARTISTS=Hiroshi Okubo". The bold part of this "ARTIST=Hiroshi Okubo (nanosounds.jp) feat. SAK." (including space) is actually the joint phrases.

2
Ideally. Auxio should just make the track artists credit to "ARTIST=Hiroshi Okubo feat. TA-KO", and when we press go to artists, it should show "ARTISTS=Hiroshi Okubo" and "ARTISTS=TA-KO"

2. [ALBUM ARTISTS CREDIT]

This is the issue from #648
For some reason, auxio uses the same album artists, even though the album is different.

MUSICBRAINZ_ALBUMARTISTID=5005beb6-9da2-48ba-bfd9-aa8ddc6d0117
MUSICBRAINZ_ALBUMARTISTID=ce4e45e8-233c-45d3-ac69-8a9ea57f42b6
MUSICBRAINZ_ALBUMARTISTID=38707e15-2bef-43bc-82d0-2a7e82acb199
MUSICBRAINZ_ALBUMARTISTID=0aa7ae8a-a5ff-46a1-8729-ffa4392cd2d6
MUSICBRAINZ_ALBUMARTISTID=f6f03430-b376-4e94-b79e-a7956f976a2f
ALBUMARTIST=MAISONdes feat. 堂村璃羽 & 301 & GeG & 安本彩花
ALBUMARTISTSORT=MAISONdes feat. Domura, Riu & 301 & GeG & Yasumoto, Ayaka

MUSICBRAINZ_ARTISTID=5005beb6-9da2-48ba-bfd9-aa8ddc6d0117
MUSICBRAINZ_ARTISTID=ce4e45e8-233c-45d3-ac69-8a9ea57f42b6
MUSICBRAINZ_ARTISTID=38707e15-2bef-43bc-82d0-2a7e82acb199
MUSICBRAINZ_ARTISTID=0aa7ae8a-a5ff-46a1-8729-ffa4392cd2d6
MUSICBRAINZ_ARTISTID=f6f03430-b376-4e94-b79e-a7956f976a2f
ARTIST=MAISONdes feat. 堂村璃羽 & 301 & GeG & 安本彩花
ARTISTSORT=MAISONdes feat. Domura, Riu & 301 & GeG & Yasumoto, Ayaka
ARTISTS=MAISONdes
ARTISTS=堂村璃羽
ARTISTS=301
ARTISTS=GeG
ARTISTS=安本彩花

The album artists for this album is "MAISONdes feat. 堂村璃羽 & 301 & GeG & 安本彩花" which is the same for the track artists because it's a single. What I think is happening is that there are 5 "MUSICBRAINZ_ALBUMARTISTID" and only 1 "ALBUMARTIST"

I think Auxio should ignore music "MUSICBRAINZ_ALBUMARTISTID" if there are multiple of them

Problem solved

No response

Other implementations

Other music player just ignore the musicbrainz id an just use based on the names, but this will create multiple duplicate artists

Benefit

This would benefit everybody

Duplicates

@ghost ghost added the enhancement New feature or request label Dec 21, 2023
@ghost ghost assigned OxygenCobalt Dec 21, 2023
@OxygenCobalt
Copy link
Owner

Duplicate of #582. I'm already considering this.

@OxygenCobalt OxygenCobalt added the duplicate This issue or pull request already exists label Dec 21, 2023
@OxygenCobalt
Copy link
Owner

OxygenCobalt commented Dec 21, 2023

The album artists for this album is "MAISONdes feat. 堂村璃羽 & 301 & GeG & 安本彩花" which is the same for the track artists because it's a single. What I think is happening is that there are 5 "MUSICBRAINZ_ALBUMARTISTID" and only 1 "ALBUMARTIST"

Exactly. I need corresponding ALBUMARTISTS to properly assign artist information. I can't just use ARTISTS, since Artists may be only a subset of Album Artists and thus will be missing some entries. What Auxio currently does is take that first MBID, combine it with the concatenated album artist, and then use that, since it is the only thing it can do. As part of #202, I'm not just going to remove support for it because of this edge case. I consider this a consequence of poor tagging rather than anything else. I hope this makes sense. @polyester2023

@ghost
Copy link
Author

ghost commented Dec 21, 2023

Is it possible for auxio to also display the joint phrases rather than comma

@OxygenCobalt
Copy link
Owner

If I'm getting the right idea, then yes, it will be part of #582 @polyester2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant