New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

channel window visibility can be toggled and stream played #13

Merged
merged 5 commits into from Jun 4, 2015

Conversation

Projects
None yet
2 participants
@maniotrix
Collaborator

maniotrix commented Jun 2, 2015

Please run src/p2psp_application_gui to review the current status of gui.

screenshot from 2015-06-02 23 49 14

screenshot from 2015-06-02 23 51 38

channels' display box visibility can be toggled from right side of menu bar.

currently known issues:

  • Player/Status Box does not hide after fullscreen(although this issue will be resolved in next commit)
  • no key-bindings anywhere in the application.
  • obviously thumbnail has to be resized.
  • proper documentation will be also done in next commit.
  • channel display box is not fully functional currently.
@josejuansanchez

This comment has been minimized.

Show comment
Hide comment
@josejuansanchez

josejuansanchez Jun 3, 2015

Member

Hi @maniotrix!

I think could be great to have the source code files organized in another way.

This is my proposal for the directory structure:

src
    - mainapplication.py

    - core
        - peer.py
        - splitter.py
        - ...

    - gui
        - vlc.py
        - ...

data
    -  glade
        - mainwindow.glade
        - ...
    - images
        - logo.png
        - ...

The src directory would contain a mainapplication.py file and the directories: core (the current source code for the protocol) and gui (the code related with the desktop app).

Furthermore, the resources (e.g. images) and .glade files would be located in the data directory.

Finally, I think that the file P2PSP_GUI.glade~ should not be included in the commit.

@maniotrix @vicente-gonzalez-ruiz @cristobalmedinalopez What do you think about this proposal?

Member

josejuansanchez commented Jun 3, 2015

Hi @maniotrix!

I think could be great to have the source code files organized in another way.

This is my proposal for the directory structure:

src
    - mainapplication.py

    - core
        - peer.py
        - splitter.py
        - ...

    - gui
        - vlc.py
        - ...

data
    -  glade
        - mainwindow.glade
        - ...
    - images
        - logo.png
        - ...

The src directory would contain a mainapplication.py file and the directories: core (the current source code for the protocol) and gui (the code related with the desktop app).

Furthermore, the resources (e.g. images) and .glade files would be located in the data directory.

Finally, I think that the file P2PSP_GUI.glade~ should not be included in the commit.

@maniotrix @vicente-gonzalez-ruiz @cristobalmedinalopez What do you think about this proposal?

@maniotrix

This comment has been minimized.

Show comment
Hide comment
@maniotrix

maniotrix Jun 3, 2015

Collaborator

Sorry for adding P2PSP_GUI.glade~ .I should have not included it for tracking.

Collaborator

maniotrix commented Jun 3, 2015

Sorry for adding P2PSP_GUI.glade~ .I should have not included it for tracking.

@maniotrix

This comment has been minimized.

Show comment
Hide comment
@maniotrix
Collaborator

maniotrix commented Jun 3, 2015

@maniotrix

This comment has been minimized.

Show comment
Hide comment
@maniotrix

maniotrix Jun 3, 2015

Collaborator

Although Player/Status box gets hidden on player fullscreen , but mouse pointer disappears when it moves to player area(with or without fullscreen). I have tried but couldn't find a solution to this problem.

Collaborator

maniotrix commented Jun 3, 2015

Although Player/Status box gets hidden on player fullscreen , but mouse pointer disappears when it moves to player area(with or without fullscreen). I have tried but couldn't find a solution to this problem.

@josejuansanchez

This comment has been minimized.

Show comment
Hide comment
@josejuansanchez

josejuansanchez Jun 4, 2015

Member

@maniotrix Don't worry about it. We can open an issue and try to fix later.

Member

josejuansanchez commented Jun 4, 2015

@maniotrix Don't worry about it. We can open an issue and try to fix later.

josejuansanchez added a commit that referenced this pull request Jun 4, 2015

Merge pull request #13 from maniotrix/gui
A first approach to GUI

@josejuansanchez josejuansanchez merged commit f873351 into P2PSP:master Jun 4, 2015

@josejuansanchez

This comment has been minimized.

Show comment
Hide comment
@josejuansanchez

josejuansanchez Jun 4, 2015

Member

@maniotrix Do you mind to file a pull request over the gui branch?
I had to revert the previous pull request (#13) because this was filed over the master branch. Sorry.

Member

josejuansanchez commented Jun 4, 2015

@maniotrix Do you mind to file a pull request over the gui branch?
I had to revert the previous pull request (#13) because this was filed over the master branch. Sorry.

josejuansanchez added a commit that referenced this pull request Jun 4, 2015

Merge pull request #17 from maniotrix/gui
resolving merge conflicts for PR(#13)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment