-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrument Packs: What Information (and Format) #16
Comments
We should probably adopt the same/similar format as for our science model packs. |
I'm in favour for allowing blend spectra, e.g. Spitzer SL and SH combined. |
I sometime wonder if |
I think that we should keep the spectra separate. This makes it much easier to create the correct model. Going a bit further, I think we should keep the spectral segments from the same instrument separate. Thinking about this for MIRI, there will be 12 grating settings to get the full 5-28 um spectrum. Merging them will be possible, but it will be conceptually easier to get the right instrument resolution for each segment if we just keep the separate. Nothing in the fitting that requires a merged spectrum. And this would allow for possibly adding in the appropriate parameters to solve for the offsets between the segments as part of the PAHFIT fitting. Better uncertainties as the fits to the features would then include the uncertainties on merging the spectra. |
The reality of spectral stitching is that it's a distinct task from model fitting, since it relies on deep (and usually hard fought) intrinsic knowledge of artifacts. Often the spectra where they overlap don't just fail to match in level, but have different slopes, apparent features in one missing in the other, etc. It takes some skill to know how far out to trust individual spectra segments, and which to trust where they overlap. Compounding this is that the ends of orders/detectors are often the most poorly calibrated. We have to decide how much such pre-existing knowledge to inject into the instrument packs. My feeling is we shouldn't go too far: that's not the business we're in, and calibrations can change and improve, and artifacts can vary with S/N. For science results, carefully blended spectra are expected. But perhaps we can keep it an option to input a bunch of spectral segments, possibly even with priors softening the weighting at the ends of the segments. In fact, as you mention, this is quite a bit cleaner in terms of mapping an instrument pack to a given spectra segment. |
Honestly, I'd love to see an astropy module that just handles spectra stitching. We have a vast collection of algorithms for IRS(+Akari), but they aren't really externally consumable. |
Spectral stitching sounds like a astropy affiliated package idea to me. Or maybe part of the specutils package? |
In class InstPackSpitzerIRSSLLL, in def__init__, there is a typo: self.instrumet instead of self.instrument |
What features of the model framework should live in separate instrument packs? I can imagine:
But what if you want to blend spectra together from multiple intstruments?
We could obviously go much further to correct response function issues, etc., but PAHFIT is not a calibration or reduction tool.
The text was updated successfully, but these errors were encountered: