ci: Fix always passing VPP plugin test #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pemoticak
force-pushed
the
fix-plugin-test-ci
branch
from
97495a8
to
6a8d79b
Compare
pemoticak
changed the title
Signed-off-by: Peter Motičák <peter.moticak@pantheon.tech>
pemoticak
force-pushed
the
fix-plugin-test-ci
branch
from
6a8d79b
to
2a59c87
Compare
pemoticak
changed the title
fgschwan
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker buildtruncated stderr output so it was redirected to stdout so user could read why the test failed. This solution was not made with much foresight, as when automatic CI testing was added later, stderr was always empty so workflow passed even when it should not.This PR should hopefully fix the issue.
Signed-off-by: Peter Motičák peter.moticak@pantheon.tech