Replace most users of SchemaInferenceStack #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rovarga
force-pushed
the
simplify
branch
2 times, most recently
from
6398b51
to
5249231
Compare
All we are tracking a collection of QNames, which we want to turn into a SchemaNodeIdentifier in opportune moments. Create a LyvStack class, which contains the bare minimum we need for state tracking. Replace use of SchemaInferenceStack with LyvStack in SchemaSelector. Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
All we need to track is the schema tree QNames we are traversing, hence there is no need for SchemaInferenceStack -- use LyvStack instead. Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
ihrasko
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary cleanups plus ditching of SchemaInferenceStack