Refactor code to improve readability and maintainability #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobianas
force-pushed
the
mainSonarcloudFix
branch
5 times, most recently
from
66c0b9f
to
e04c09f
Compare
Tobianas
force-pushed
the
mainSonarcloudFix
branch
from
e04c09f
to
167bde2
Compare
ihrasko
requested changes
Sep 22, 2023
.../main/java/io/lighty/gnmi/southbound/mountpoint/codecs/GetResponseToNormalizedNodeCodec.java
Show resolved
Hide resolved
...etconf/src/main/java/io/lighty/core/controller/springboot/rest/NetconfDeviceRestService.java
Outdated
Show resolved
Hide resolved
This return statement returned the first notification update it found, making the for loop unnecessary. Just remove the iteration and return first from the list. JIRA: LIGHTY-235 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Add a null check to ensure that the values are not null. JIRA: LIGHTY-235 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Improve the return of this method and conditions to make it more readable. JIRA: LIGHTY-235 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Tobianas
force-pushed
the
mainSonarcloudFix
branch
from
167bde2
to
fd8d1cb
Compare
ihrasko
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also resolves bugs reported by sonarcloud.
JIRA: LIGHTY-235