Fix gNMI simulator to handle update with non-string list key types #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihrasko
requested changes
Feb 16, 2024
...ice-simulator/src/main/java/io/lighty/modules/gnmi/simulatordevice/gnmi/GnmiCrudService.java
Outdated
Show resolved
Hide resolved
...ty-gnmi/lighty-gnmi-commons/src/main/java/io/lighty/modules/gnmi/commons/util/JsonUtils.java
Outdated
Show resolved
Hide resolved
PeterSuna
force-pushed
the
main-fixGnmi
branch
from
7010d05
to
9f48e8c
Compare
PeterSuna
force-pushed
the
main-fixGnmi
branch
from
9f48e8c
to
6ffbdb3
Compare
Previously, the List key was always set as a String for YangInstanceIdentifier generated from gNMI path. This prevented data from being merged into the datastore, as this type of key was not found in the datastore. This commit addresses the issue by setting the correct value defined in the typeDefinition QName. JIRA: LIGHTY-285 Signed-off-by: Peter Suna <peter.suna@pantheon.tech> Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Utilizing Gson to convert key values from
NodeIdentifierWithPredicates may produce unexpected outcomes
if the key value is not parsable by Gson's default behavior.
For instance, the result for Uint8(10) would be {"value":10}
instead of simply 10.
Ensure custom ODL types are correctly parsed by Gson.
JIRA: LIGHTY-285
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
ihrasko
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the List key was always set as a String for YangInstanceIdentifier generated from gNMI path. This prevented data from being merged into the datastore, as this type of key was not found in the datastore.
Fixing this shows another issue with JsonUtils that prepare Json payload for datastore. JsonUtils using Gson to convert key values from NodeIdentifierWithPredicates. This may produce unexpected outcomes if the key value is not parsable by Gson's default behavior. For instance, the result for Uint8(10) would be {"value":10} instead of simply 10.