Set correct List key type in gNMI simulator #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the List key was always set as a String for YangInstanceIdentifier generated from gNMI path. This prevented data from being merged into the datastore, as this type of key was not found in the datastore. This commit addresses the issue by setting the correct value defined in the typeDefinition QName. JIRA: LIGHTY-285 Signed-off-by: Peter Suna <peter.suna@pantheon.tech> Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit 78ae7fd)
ihrasko
force-pushed
the
18.x-set-correct-list-key-type
branch
from
0b8cc05
to
c0653b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the List key was always set as a String for YangInstanceIdentifier generated from gNMI path. This prevented data from being merged into the datastore, as this type of key was not found in the datastore.
This commit addresses the issue by setting the correct value defined in the typeDefinition QName.
JIRA: LIGHTY-285
Signed-off-by: Peter Suna peter.suna@pantheon.tech
Signed-off-by: Ivan Hrasko ivan.hrasko@pantheon.tech
(cherry picked from commit 78ae7fd)