Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix critical code smell reported by SonnarCloud - 14.2.x (cherry-pick #818) #823

Merged
merged 6 commits into from Sep 17, 2021
Merged

Fix critical code smell reported by SonnarCloud - 14.2.x (cherry-pick #818) #823

merged 6 commits into from Sep 17, 2021

Conversation

vainyksi
Copy link
Contributor

Fixed critical code smells:

  • String literals should not be duplicated
  • Class members annotated with "VisibleForTesting" should not be accessed from production code
  • Cognitive Complexity of methods should not be too high
  • Methods should not be empty

Won't do code smells:

cherry-picks #818

PeterSuna and others added 6 commits September 17, 2021 17:13
@PeterSuna
Fix duplicated String literals reported by SonnarCloud
366d990 
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
(cherry picked from commit f7e9d29)
@PeterSuna
Remove default constructor reported by SonnarCloud
38e90d3 
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
(cherry picked from commit 4e40a51)
@PeterSuna
Remove creating class instances with VisibleForTesting annotation
0d61135 
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
(cherry picked from commit df3f595)
@PeterSuna
Fix cognitive complexity reported by SonnarCloud
1136568 
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
(cherry picked from commit 0f226ca)
Rename parseControllerConfig and minor code format update
31aab98 
Signed-off-by: Michal Banik <michal.banik@pantheon.tech>
(cherry picked from commit 6d6949a)
Small code-refator & rename
b3b49c4 
Signed-off-by: Michal Banik <michal.banik@pantheon.tech>
(cherry picked from commit 468fbd5)
@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2021 •
edited

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

95.0% 95.0% Coverage
0.0% 0.0% Duplication

@vainyksi vainyksi merged commit 4b66eb4 into 14.2.x Sep 17, 2021
@vainyksi vainyksi deleted the 14.2.x_fixCriticalCodeSmell branch September 17, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vainyksi @PeterSuna