Skip to content
This repository has been archived by the owner on Apr 15, 2022. It is now read-only.

update config.json #4

Closed
wants to merge 1 commit into from
Closed

update config.json #4

wants to merge 1 commit into from

Conversation

erikyuzwa
Copy link
Contributor

missing reference to logic-portable component

missing reference to logic-portable component
@mcscooter
Copy link
Member

I think we purposely removed references to components that are not used in the bare bones demo. Do you think it would be useful to include all possible components in the default config.JSON?

@probityrules
Copy link
Contributor

The number of components is pretty large. I would recommend including them as a commented-out list if we do include them.

This particular component is referenced by hero.json, but hero.json doesn't use it for anything any more. So it should be removed from hero.json, not added here. (unless we want to add everything?)

@erikyuzwa
Copy link
Contributor Author

@scott, I understand but this reference was getting called ( by hero.json as pointed out by Derek)

@derek, definitely I'd opt for removing whatever isn't necessary. My bad, I should've gone through hero then to double check that angle.

On Nov 5, 2013, at 9:05 AM, Derek Detweiler notifications@github.com wrote:

The number of components is pretty large. I would recommend including them as a commented-out list if we do include them.

This particular component is referenced by hero.json, but hero.json doesn't use it for anything any more. So it should be removed from hero.json, not added here. (unless we want to add everything?)


Reply to this email directly or view it on GitHub.

@probityrules
Copy link
Contributor

I removed the hero.json reference. Regarding the full list of components, I'm thinking we could change the wiki so that there is a single page dedicated just to listing available engine components and maybe have a comment in the example config that points to that page.

@mcscooter
Copy link
Member

Good idea on the component list! We need a space for people to share new components they make as well and that could serve that purpose.

@erikyuzwa erikyuzwa deleted the patch-2 branch November 6, 2013 03:51
@erikyuzwa
Copy link
Contributor Author

I like that as well, good stuff @probityrules.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants