Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiment_id requested for obs4MIPs data #209

Closed
durack1 opened this issue Jul 21, 2017 · 4 comments
Closed

experiment_id requested for obs4MIPs data #209

durack1 opened this issue Jul 21, 2017 · 4 comments

Comments

@durack1
Copy link
Contributor

durack1 commented Jul 21, 2017

This error suggests that experiment_id is a hard-coded element, this field is not applicable for the obs4MIPs project.

@taylor13 @dnadeau4 pinging you both here, this relates to the code in PCMDI/obs4MIPs-cmor-tables#60

(cmor325) bash-3.2$ python runCmorDemo.py 

C Traceback:
! In function: cmor_get_cur_dataset_attribute
! called from: _CV_checkExperiment
! called from: cmor_setGblAttr
! called from: cmor_write
! 

!!!!!!!!!!!!!!!!!!!!!!!!!
!
! Error: Dataset: current dataset does not have attribute : experiment_id
!
!!!!!!!!!!!!!!!!!!!!!!!!!


C Traceback:
! In function: _CV_checkExperiment
! called from: cmor_setGblAttr
! called from: cmor_write
! 

!!!!!!!!!!!!!!!!!!!!!!!!!
!
! Error: Your "experiment_ids" key could not be found in
! your Control Vocabulary file.(.//obs4MIPs_CV.json)
! 
!
!!!!!!!!!!!!!!!!!!!!!!!!!


C Traceback:
In function: cmor_setGblAttr
! called from: cmor_write
! 

!!!!!!!!!!!!!!!!!!!!!!!!!
!
! Warning: The further info in attribute does not match the one found in your Control Vocabulary(CV) File. 
! We found "https://furtherinfo.es-doc.org/<activity_id><institution_id><source_label><variable_id>" and 
! CV requires "https://furtherinfo.es-doc.org/obs4MIPs.RSS.REMSS-PRW.prw" 
! Check your Control Vocabulary file ".//obs4MIPs_CV.json".
! 
!
!!!!!!!!!!!!!!!!!!!!!!!!!


C Traceback:
! In function: cmor_get_cur_dataset_attribute
! called from: _CV_checkParentExpID
! called from: cmor_write
! 

!!!!!!!!!!!!!!!!!!!!!!!!!
!
! Error: Dataset: current dataset does not have attribute : experiment_id
!
!!!!!!!!!!!!!!!!!!!!!!!!!


C Traceback:
! In function: _CV_checkParentExpID
! called from: cmor_write
! 

!!!!!!!!!!!!!!!!!!!!!!!!!
!
! Error: Your "experiment_id" key could not be found in
! your Control Vocabulary file.(.//obs4MIPs_CV.json)
! 
!
!!!!!!!!!!!!!!!!!!!!!!!!!


C Traceback:
! In function: cmor_get_cur_dataset_attribute
! called from: _CV_checkSubExperiment
! called from: cmor_write
! 

!!!!!!!!!!!!!!!!!!!!!!!!!
!
! Error: Dataset: current dataset does not have attribute : experiment_id
!
!!!!!!!!!!!!!!!!!!!!!!!!!


C Traceback:
! In function: _CV_checkSubExperiment
! called from: cmor_write
! 

!!!!!!!!!!!!!!!!!!!!!!!!!
!
! Error: Your "sub_experiment_id" key could not be found in
! your Control Vocabulary file.(.//obs4MIPs_CV.json)
! 
!
!!!!!!!!!!!!!!!!!!!!!!!!!


C Traceback:
! In function: 

!!!!!!!!!!!!!!!!!!!!!!!!!
!
! Error: Cannot continue until you fix the errors listed above: -4
!
!!!!!!!!!!!!!!!!!!!!!!!!!

Traceback (most recent call last):
  File "runCmorDemo.py", line 55, in <module>
    cmor.write(varid,values,time_vals=time[:],time_bnds=time.getBounds()) ; # Write variable with time axis
  File "/Users/durack1/anaconda2/envs/cmor325/lib/python2.7/site-packages/cmor/pywrapper.py", line 795, in write
    time_vals, time_bnds, store_with)
_cmor.CMORError: Problem with 'cmor.write'. Please check the logfile (if defined).
@sfinkens
Copy link

I think this might be related: PCMDI/obs4MIPs-cmor-tables#35

For other experiment, you need to take this out:
_cmip6_option": "CMIP6",
or set it to some other string. This triggers a bunch of verification that you do not need.

@taylor13
Copy link
Collaborator

I agree, but unless we didn't do it correctly, we meant to set _cmip6_option to "off", so we wouldn't trigger the tests. We'll need to double check. thanks.

@dnadeau4
Copy link
Collaborator

dnadeau4 commented Jul 24, 2017

I looked at the code, and I only check if _cmip6_option is defined, but not its value. I can change that if needed. For now just remove the line entirely to make sure you don't trigger CMIP6 checks.

By removing the line, _cmip6_option will not be defined in the dataset.

cmor_has_cur_dataset_attribute(GLOBAL_IS_CMIP6) == 0)

@durack1
Copy link
Contributor Author

durack1 commented Jul 24, 2017

@dnadeau4 your note above is accurate with CMOR3.2.5, once I remove this line the experiment_id error disappears, so I will close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants