Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendorizing json-c #469

Closed
xylar opened this issue Apr 10, 2019 · 5 comments · Fixed by #474
Closed

vendorizing json-c #469

xylar opened this issue Apr 10, 2019 · 5 comments · Fixed by #474
Assignees

Comments

@xylar
Copy link

xylar commented Apr 10, 2019

As posted on the conda-forge feedstock, the latest cmor (3.4.0) seems to vendorize json-c. This may not be a problem outside of the conda-forge feedstock but on conda-forge it clobbers any installation of the conda-forge package json-c:

This transaction has incompatible packages due to a shared path.
  packages: conda-forge::json-c-0.13.1-h14c3975_1001, conda-forge::cmor-3.4.0-py27h17cb6a4_2
  path: 'include/json-c/arraylist.h'
If you'd like to proceed anyway, re-run the command with the `--clobber` flag.
.
This transaction has incompatible packages due to a shared path.
  packages: conda-forge::json-c-0.13.1-h14c3975_1001, conda-forge::cmor-3.4.0-py27h17cb6a4_2
  path: 'include/json-c/bits.h'
If you'd like to proceed anyway, re-run the command with the `--clobber` flag.
.
This transaction has incompatible packages due to a shared path.
  packages: conda-forge::json-c-0.13.1-h14c3975_1001, conda-forge::cmor-3.4.0-py27h17cb6a4_2
  path: 'include/json-c/debug.h'
If you'd like to proceed anyway, re-run the command with the `--clobber` flag.
...

I'm not completely sure if this is an issue that needs to be addressed here or in the conda-forge feedstock.

@dnadeau4
Copy link
Collaborator

dnadeau4 commented Apr 23, 2019

They are many json-c readers out there and I was afraid that json-c package would disappear 2 years ago. Do you know who won the "coke/pepsi" war for JSON-C?

@xylar
Copy link
Author

xylar commented Apr 23, 2019

Thanks for the info. I'm sure this has been tricky.

According to the feedstock:
https://github.com/conda-forge/json-c-feedstock/blob/master/recipe/meta.yaml#L35
The source is:
https://github.com/json-c/json-c

Do you know if that's what you ended up vendorizing?

@dnadeau4
Copy link
Collaborator

Yes that is the same one I used. Nice to see that it is on conda-forge now.

@dnadeau4
Copy link
Collaborator

Interesting to see that the meta.yaml takes the source from amazon and not github.

@xylar
Copy link
Author

xylar commented Apr 23, 2019

I thought that was odd, too, but it's what the Wiki suggests. I wonder if the json-c developers aren't fully aware that GitHub does this for you so you don't have to host elsewhere...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants