Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message mis-match #542

Closed
sterlingbaldwin opened this issue Sep 10, 2019 · 3 comments · Fixed by #581
Closed

Error message mis-match #542

sterlingbaldwin opened this issue Sep 10, 2019 · 3 comments · Fixed by #581

Comments

@sterlingbaldwin
Copy link
Collaborator

The error message here should match the if condition on the previous line.

@sterlingbaldwin
Copy link
Collaborator Author

Also, just on a stylistic point, the word "type" should not be used as a variable as its a built in python method. The error message should actually give the allowed datatypes instead of just "i" for int, and "d" for double.

@mauzey1
Copy link
Collaborator

mauzey1 commented Mar 5, 2020

@sterlingbaldwin The 'S' and 'U' in the line you linked refer to the byte and unicode types for strings in numpy arrays. #581 changes the letters to int32, int64, float32, float64, and string. Do you approve of these changes?

@sterlingbaldwin
Copy link
Collaborator Author

Sounds good to me, should be a lot easier to debug given the actual type instead of the letter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants