-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error message mis-match #542
Comments
Also, just on a stylistic point, the word "type" should not be used as a variable as its a built in python method. The error message should actually give the allowed datatypes instead of just "i" for int, and "d" for double. |
@sterlingbaldwin The 'S' and 'U' in the line you linked refer to the byte and unicode types for strings in numpy arrays. #581 changes the letters to int32, int64, float32, float64, and string. Do you approve of these changes? |
Sounds good to me, should be a lot easier to debug given the actual type instead of the letter. |
The error message here should match the if condition on the previous line.
The text was updated successfully, but these errors were encountered: