"call to undeclared function 'calculate_leadtime_coord'" error in recent Xcode/Clang build for OSX

[mauzey1]

While building CMOR on my Macbook I encountered the following error.

Src/cmor.c:4859:9: error: call to undeclared function 'calculate_leadtime_coord'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        calculate_leadtime_coord(var_id);

I'm currently using Xcode 15.0 on OSX Ventura. I've been building CMOR on my Mac just fine until recently. This issue might have arisen after I rebuilt my Conda environment with the latest version of Clang.

Regardless, the error is caused by the call to the function calculate_leadtime_coord in cmor.c before its declaration. The simplest solution would be to just declare the function near the top of the file.

[matthew-mizielinski]

@piotr-florek-mohc, I'm guessing that you didn't see this when doing the leadtime work?

[piotr-florek-mohc]

no I haven't - seems like an embarrassingly rookie mistake!

[mauzey1]

I never caught it either until the changes to the compiler flagged it as an error.

@piotr-florek-mohc, if you want to make some fixes to this I could hand this issue over to you. I also noticed there were some functions in the Python wrapper that were meant to point this function until it was decided not to expose it in the API.

[piotr-florek-mohc]

Sure, I can fix both!