Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation under fedora 28 #2417

Closed
lucag73 opened this issue May 2, 2018 · 4 comments
Closed

Compilation under fedora 28 #2417

lucag73 opened this issue May 2, 2018 · 4 comments

Comments

@lucag73
Copy link

lucag73 commented May 2, 2018

PCSX2 version:
Git release: 4de2df2
Description of the issue:
Compilation of pcsx2 with gcc8 in Fedora28 fails since _xgetbv is already defined

How to reproduce the issue:

  1. install fedora 28 (with all of the relevant packages for compiling pcsx2)
  2. build with ./build.sh --release --gtk3
  3. the compilation fails as soon as common/include/x86emitter/x86_intrin.h is included

The issue can be fixed by adding in the aforementioned file a
#define _XSAVEINTRIN_H_INCLUDED
which prevents the inclusion of /usr/lib/gcc/x86_64-redhat-linux/8/include/xsaveintrin.h
but this is clearly a hack.

@gregory38
Copy link
Contributor

We need to check how _xgetbv is implemented on gcc8 and remove our definition if already defined or if gcc >= 8

@gregory38
Copy link
Contributor

Yes we should use gcc implementation by default

@turtleli
Copy link
Member

turtleli commented May 4, 2018

#2419 should fix the issue.

@lucag73
Copy link
Author

lucag73 commented May 6, 2018

I posted in #2419 ... with this fix compilation works, but pcsx2 segfaults on start...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants