Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Half pixel offset only works in certain levels #6634

Closed
mirh opened this issue Jul 15, 2022 · 2 comments
Closed

[BUG]: Half pixel offset only works in certain levels #6634

mirh opened this issue Jul 15, 2022 · 2 comments
Labels

Comments

@mirh
Copy link

mirh commented Jul 15, 2022

Describe the Bug

Half pixel offset seems to do anything at all only in some levels.
Where it works, the "viewport" is indeed offsetted a bit, and it leads to a sensible increase in textures detail too.
Elsewhere, nothing.

Reproduction Steps

Apply 4x resolution.
In Ace combat 5: compare level 13 "Demons of Razgriz" to level 3 "Narrow Margin" (or menus).
Try to toggle Half Pixel Offset.

Expected Behavior

Now, I don't really have a benchmark to tell whether this leads to washed out textures in the missions where it doesn't apply (and this is eventually the only thing that you'd want to care)
But the menus not moving at all seems to give pretty safely away the fact that something's broken somewhere.

PCSX2 Revision

v1.7.3073

Operating System

Windows 10 (64bit)

CPU

i5-10300H

GPU

RTX 3060 laptop

Logs & Dumps

snaps.zip
(if you compare the provided screenshots, you can notice how the UI is ever so slightly shifted in the "works" case)

@lightningterror
Copy link
Contributor

That's how it's supposed to work, it doesn't cover all types of draws, it's a hack, and where it doesn't work you use other type of upscaling hacks.

@lightningterror lightningterror closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2022
@mirh
Copy link
Author

mirh commented Dec 11, 2022

Different levels using different rendering coordinates/arrangements/techniques could make sense I guess.
But it seems so odd that even the same usual boring 2D menus would be catched into this game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants