Merge branch 'master' into azp

PDAL · Jul 23, 2019 · 3f8d821 · 3f8d821
2 parents 55f738b + 28541f6
commit 3f8d821
Show file tree

Hide file tree

Showing 46 changed files with 647 additions and 2,937 deletions.
diff --git a/PDALConfig.cmake.in b/PDALConfig.cmake.in
@@ -17,11 +17,6 @@ endforeach(_dir)
 
 include("${CMAKE_CURRENT_LIST_DIR}/PDALTargets.cmake")
 
-if (WIN32)
-# On windows link in pdal_util as well
-  set(PDAL_LIBRARIES "@PDAL_LIB_NAME@" "@PDAL_UTIL_LIB_NAME@")
-else (WIN32)
-  set(PDAL_LIBRARIES "@PDAL_LIB_NAME@")
-endif(WIN32)
+set(PDAL_LIBRARIES @PDAL_BASE_LIB_NAME@ @PDAL_UTIL_LIB_NAME@) 
 
 check_required_components(PDAL)
diff --git a/cmake/options.cmake b/cmake/options.cmake
@@ -22,11 +22,6 @@ option(BUILD_PLUGIN_I3S
 add_feature_info("I3S plugin" BUILD_PLUGIN_I3S
     "Read from a I3S server or from a SLPK file")
 
-option(BUILD_PLUGIN_GREYHOUND
-    "Choose if Greyhound support should be built" FALSE)
-add_feature_info("Greyhound plugin" BUILD_PLUGIN_GREYHOUND
-    "read points from a Greyhound server")
-
 option(BUILD_PLUGIN_ICEBRIDGE
     "Choose if Icebridge support should be built" FALSE)
 add_feature_info("Icebridge plugin" BUILD_PLUGIN_ICEBRIDGE

diff --git a/doc/stages/readers.greyhound.rst b/doc/stages/readers.greyhound.rst
diff --git a/doc/stages/readers.rst b/doc/stages/readers.rst
@@ -8,7 +8,7 @@ normalize common dimension types, like X, Y, Z, or Intensity, which are often
 found in LiDAR point clouds. Not all dimension types need to be fixed, however.
 Database drivers typically return unstructured lists of dimensions.  A reader
 might provide a simple file type, like :ref:`readers.text`, a complex database
-like :ref:`readers.oci`, or a network service like :ref:`readers.greyhound`.
+like :ref:`readers.oci`, or a network service like :ref:`readers.ept`.
 
 
 .. toctree::
@@ -23,7 +23,6 @@ like :ref:`readers.oci`, or a network service like :ref:`readers.greyhound`.
    readers.faux
    readers.gdal
    readers.geowave
-   readers.greyhound
    readers.i3s
    readers.ilvis2
    readers.las
@@ -73,9 +72,6 @@ like :ref:`readers.oci`, or a network service like :ref:`readers.greyhound`.
 :ref:`readers.geowave`
     Read point cloud data from Accumulo.
 
-:ref:`readers.greyhound`
-    Query point cloud data from a Greyhound server.
-
 :ref:`readers.i3s`
     Read data stored in the Esri I3S format.  The data is read from an
     appropriate server.

diff --git a/doc/stages/writers.greyhound.rst b/doc/stages/writers.greyhound.rst
diff --git a/doc/stages/writers.rst b/doc/stages/writers.rst
@@ -21,7 +21,6 @@ dimension type, while others only understand fixed dimension names.
    writers.e57
    writers.gdal
    writers.geowave
-   writers.greyhound
    writers.las
    writers.matlab
    writers.nitf
@@ -51,10 +50,6 @@ dimension type, while others only understand fixed dimension names.
 :ref:`writers.geowave`
     Write point cloud data to Accumulo.
 
-:ref:`writers.greyhound`
-    Append new dimensions (or update existing dimensions) onto a Greyhound
-    resource. Must be used along with a Greyhound reader, and intermediate
-    filters that cull points are not allowed.
 
 :ref:`writers.las`
     Write ASPRS LAS versions 1.0 - 1.4 formatted data. LAZ support is also

diff --git a/filters/PlaneFitFilter.cpp b/filters/PlaneFitFilter.cpp
@@ -136,7 +136,6 @@ void PlaneFitFilter::setPlaneFit(PointView& view, const PointId& i,
     Eigen::SelfAdjointEigenSolver<Eigen::Matrix3d> solver(B);
     if (solver.info() != Eigen::Success)
         throwError("Cannot perform eigen decomposition.");
-    auto eval = solver.eigenvalues();
     Eigen::Vector3d normal = solver.eigenvectors().col(0);
 
     // Compute point to plane distance of the query point.