only allow filters.shell if PDAL_ALLOW_SHELL environment variable is set

PDAL · Mar 31, 2019 · 99b9e07 · 99b9e07
1 parent 239480e
commit 99b9e07
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/filters/ShellFilter.cpp b/filters/ShellFilter.cpp
@@ -67,6 +67,10 @@ void ShellFilter::addArgs(ProgramArgs& args)
 
 void ShellFilter::initialize()
 {
+	std::string allowed;
+    int set = Utils::getenv("PDAL_ALLOW_SHELL", allowed);
+	if (set == -1)
+		throw pdal::pdal_error("PDAL_ALLOW_SHELL environment variable not set, shell access is not allowed");
 }
 
 

diff --git a/test/unit/filters/ShellFilterTest.cpp b/test/unit/filters/ShellFilterTest.cpp
@@ -44,7 +44,7 @@ using namespace pdal;
 TEST(ShellFilterTest, test_shell_filter)
 {
     PipelineManager mgr;
-
+	Utils::setenv("PDAL_ALLOW_SHELL", "1");
     mgr.readPipeline(Support::configuredpath("pipeline/shell.json"));
 
     mgr.execute();