Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chipper has pathological query pattern #167

Closed
hobu opened this issue Jul 25, 2013 · 1 comment
Closed

Chipper has pathological query pattern #167

hobu opened this issue Jul 25, 2013 · 1 comment

Comments

@hobu
Copy link
Member

hobu commented Jul 25, 2013

With the work in #159, the chipper now has to do dimension lookups every time for every point because it reads one point at a time.

@c42f
Copy link
Contributor

c42f commented Jul 27, 2013

Doesn't the chipper just call copyPointsFast() when it's doing the one-at-a-time thing? If I'm reading things correctly that shouldn't involve dimension lookup.

I think there's a different problem. If I run valgrind against pcpipeline test/perf/chipper.xml (which includes a filters.cache larger than all the points in autzen-thin.las), I still get 10653 calls recorded against pdal::drivers::las::PointDimensions::PointDimensions() - one for each point. Shouldn't the cache just read them in once?

Not sure I understand what's going on here :)

Here's what I'm using for profiling.

  1. Create a release build with debug info turned on
  2. Run valgrind on test/perf/chipper.xml as follows:
    valgrind --tool=callgrind --simulate-cache=yes pcpipeline chipper.xml
  3. Check out the results in kcachegrind

@hobu hobu closed this as completed Sep 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants