Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextReader fails with space delimiter on windows with cr/lf line endings #1939

Closed
abellgithub opened this issue Apr 18, 2018 · 0 comments
Closed

TextReader fails with space delimiter on windows with cr/lf line endings #1939

abellgithub opened this issue Apr 18, 2018 · 0 comments
Milestone
1.7.2

Comments

@abellgithub
Copy link
Contributor

No description provided.

abellgithub added a commit that referenced this issue Apr 18, 2018
@abellgithub
Read files with text mode to fix separator issue on windows.
e61dd23 
Close #1939
@hobu hobu added this to the 1.7.2 milestone Apr 20, 2018
@abellgithub abellgithub mentioned this issue Apr 23, 2018
Merged
hobu pushed a commit that referenced this issue Apr 23, 2018
@abellgithub @hobu
Handle cr/lf endings on Windows in readers.text (#1963)
0e4263d 
* Use ; for path separator on Windows.

* Update tests to match code.

* Use text mode for reading files.

* Read files with text mode to fix separator issue on windows.
Close #1939

* Fix reversed logic.

* Revert change WRT spaces.
hobu pushed a commit that referenced this issue Apr 23, 2018
@abellgithub @hobu
Handle cr/lf endings on Windows in readers.text (#1963)
7b13887 
* Use ; for path separator on Windows.

* Update tests to match code.

* Use text mode for reading files.

* Read files with text mode to fix separator issue on windows.
Close #1939

* Fix reversed logic.

* Revert change WRT spaces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.2
Development

No branches or pull requests
2 participants
@hobu @abellgithub