Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to limit max triangle edge length #3924

Open
zdila opened this issue Jan 8, 2023 · 8 comments
Open

Add option to limit max triangle edge length #3924

zdila opened this issue Jan 8, 2023 · 8 comments

Comments

@zdila
Copy link
Contributor

zdila commented Jan 8, 2023

Describe the bug

Please add option to limit max triangle edge length. I am not sure if it should belong to filters.delaunay or to filters.faceraster.

Just for the reference - Whitebox Tools has this option - whitebox_tools -r=LidarDigitalSurfaceModel --max_triangle_edge_length=5 ....

System/installation information:

Linux bono 6.0.0-6-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.0.12-1 (2022-12-09) x86_64 GNU/Linux
pdal 2.3.0 (git-version: Release)
@hobu
Copy link
Member

hobu commented Jan 8, 2023

see #3928 3928

@abellgithub
Copy link
Contributor

I don't think this is doing what you want. This filter creates a raster from an existing triangulation. The edge length is the edge length of the raster cell.

In general, there's no way to limit the edge length of a triangulation of points because points might simply be too far apart to meet the request. Perhaps the OP can refer to an existing algorithm?

@hobu
Copy link
Member

hobu commented Jan 9, 2023

ah, I was confused on what edgeLength mean

@zdila
Copy link
Contributor Author

zdila commented Feb 10, 2023

@abellgithub
Copy link
Contributor

That's not a delaunay triangulation. You can't guarantee edge length with a delaunay triangulation.

@wonder-sk
Copy link
Contributor

I think the idea was to make filters.faceraster optionally ignore triangles where the edge length > X when rasterizing triangles (rather than constraining triangle size in Delaunay triangulation)... The assumption is that triangles with long edge(s) would go across "holes" in point cloud data, and that would be a simple way of filtering them out.

@zdila
Copy link
Contributor Author

zdila commented Feb 18, 2023

Please reopen.

@hobu hobu reopened this Feb 19, 2023
@hobu
Copy link
Member

hobu commented Feb 19, 2023

If you have a PR to implement this we will consider merging it. I'm not going to try again 😄

hobu pushed a commit that referenced this issue Jul 21, 2023
…4114)

* Implement max_triangle_edge_length for FaceRasterFilter (see #3924)

* wrapped long lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants