Windows 2015 warnings rollup #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only export functions, not entire class to shut up MSVC about exporting STL containers
abellgithub
reviewed
Nov 11, 2016
| @@ -362,7 +362,7 @@ int SpatialReference::calculateZone(double lon, double lat) | |||
| // Everywhere else. | |||
| else | |||
| { | |||
| zone = floor((lon + 180.0) / 6) + 1; | |||
| zone = (int) floor((lon + 180.0) / 6) + 1; | |||
There was a problem hiding this comment.
It complains about THIS? So silly. Makes me shudder for thoughts of lint.
| @@ -54,7 +54,7 @@ std::string TransformationFilter::getName() const { return s_info.name; } | |||
| TransformationMatrix transformationMatrixFromString(const std::string& s) | |||
| { | |||
| std::istringstream iss(s); | |||
| TransformationMatrix matrix; | |||
| TransformationMatrix matrix{ 0 }; | |||
There was a problem hiding this comment.
Sometimes the programmer does know better :)
| @@ -106,7 +106,7 @@ inline Everything extractDim(Extractor& ext, Dimension::Type type) | |||
| { | |||
| using Type = Dimension::Type; | |||
|
|
|||
| Everything e; | |||
| Everything e{ 0 }; | |||
There was a problem hiding this comment.
This is a bit of performance sensitive code. The optimizer may eliminate the unnecessary initialization, but I'm not sure. Certainly this is an unnecessary initialization, though.
There was a problem hiding this comment.
Can we just suppress the warning?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1361, I got a MSVC 2015 build system going and attempted to clean up all of the warnings it was complaining about so we have a better chance of seeing changes in the output as development continues.