Improve filters.stats #2034
Merged
Improve filters.stats #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify a little math. Add comments.
hobu
approved these changes
May 23, 2018
|
I think the default argument is there on line 60. Are we talking about two different things? |
|
Oh I missed it on the diff. All good.
… On May 23, 2018, at 3:40 PM, Andrew Bell ***@***.***> wrote:
I think the default argument is there on line 60. Are we talking about two different things?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate some unnecessary math.
Put skewness and kurtosis under an advanced option.
Improve tests.
Close #1878