Replace 'pdal ground' kernel usage of filters.pmf with filters.smrf¬ #2427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hobu
commented
Mar 27, 2019
hobu
commented
- add 'ignore' and 'returns' option¬
- reflect filters.smrf options
* add 'ignore' and 'returns' option¬ * reflect filters.smrf options
chambbj
requested changes
Mar 27, 2019
| @@ -81,6 +81,12 @@ void GroundKernel::addSwitches(ProgramArgs& args) | |||
| args.add("extract", "Extract ground returns?", m_extract); | |||
| args.add("reset", "Reset classifications prior to segmenting?", m_reset); | |||
| args.add("denoise", "Apply statistical outlier removal prior to segmenting?", m_denoise); | |||
| args.add("returns", "Include last returns?", m_returns, | |||
| {"last", "only"}); | |||
| args.add("scalar", "Elevation scalar?", m_scalar, 1.25); | |||
There was a problem hiding this comment.
You add the scalar arg, but never set it as an option.
chambbj
approved these changes
Mar 27, 2019
|
needs docs modified. Perhaps wait until I merge the 1.9 changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.