E57 fixes #2530
Merged
E57 fixes #2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Map cartesianInvalidState to pdal::Dimension::Id::Omit. Allows filtering out invalid points later in the pipeline. Also map nor:normal[XYZ] to pdal::Dimension::Id::Normal[XYZ].
|
Nice one! The support for normal information would not be totally functional though, for example if a point cloud as a transformation matrix set in the e57 file then the normals would need to be transformed accordingly. |
|
@abellgithub Not sure it is wise to merge as is. After this, normals will be read from the e57 files but they will be wrong whenever the e57 file contains pose information (rotated scan for example). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #2529