In a pipeline, infer the reader type from filename in the absence of a type attr #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a StageFactory::inferReaderDriver() method that takes only a filename, no options. The provided options were not used as part of the inference process, so the base method should not required them. The original inferReaderDriver(std::string, Options) has been updated to call this new method.
Add logic in PipelineReader::parseElement_Reader to attempt to infer the reader type from a filename provided in the options, in absence of a explicit type. Fixes PDAL#278.
|
👍 on removing the 2-argument call. |
Conflicts: src/StageFactory.cpp
hobu
added a commit
that referenced
this pull request
May 6, 2014
In a pipeline, infer the reader type from filename in the absence of a type attr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two commits allow PDAL to infer the reader type from the reader's filename, instead of having to explicitly find the driver type in the pipeline.
In addition to beefing up a bit of logic in the
PipelineReader, this pull request also adds a simplerStageFactory::inferReaderDriverstatic method that does not require any options as a second argument. These options were not used as part of the inference process, so I added a simpler method that just takes the filename and returns the appropriate driver type, if found. The old method has been updated to delegate the inference to this new method.