Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove personal configuration scripts #342

Merged
merged 1 commit into from May 2, 2014

Conversation

hobu
Copy link
Member

@hobu hobu commented May 2, 2014

Getting nitpicky here, but...well...sometimes that happens. There are at least four personal configuration files in our tree:

  • hobu-config.sh
  • hobu-windows.bat
  • mpg-config.bat
  • pramsey-config.sh

IMO those don't need to live in the tree. If folks need to store/version their configuration scripts, maybe they could use a gist coupled with exclude patterns in $GIT_DIR/info/exclude?

@hobu
Copy link
Member

hobu commented May 1, 2014

Ok, maybe we don't need four of them, but they do provide a good example for someone to bootstrap a configuration for themselves. This isn't as big of an issue now that we have the Vagrant configuration which allows them to do things up completely automatic.

I find having my configuration in the tree really convenient. I hop/build PDAL on at least three different machines and three different platforms. I reconfigure from scratch and rebuild different configurations frequently to test lots of permutations. Easy access to have them come down with a checkout allows me to be lazy.

I don't care if anyone takes this basic configuration and allows it to be personalized so there isn't so much duplication and specificity to myself.

@gadomski
Copy link
Member Author

gadomski commented May 2, 2014

That's fair. I feel like we are still in the stage where convenience-to-developer trumps cleanliness of source tree for sure.

Would it hose you to move the configs to some sort of subdirectory, instead of top level? I'm thinking possibly config/, configs/, cmake/examples/, cmake/config/? Or similar? For some reason seeing three people's names in the top level when I load PDAL/PDAL is getting to me.

And if I'm just being irritating let me know and I'll let it go. Not a big deal. Just was on a bit of a cleaning binge...

@hobu
Copy link
Member

hobu commented May 2, 2014

Would it hose you to move the configs to some sort of subdirectory, instead of top level? I'm thinking possibly config/, configs/, cmake/examples/, cmake/config/? Or similar? For some reason seeing three people's names in the top level when I load PDAL/PDAL is getting to me.

I can do that.

hobu added a commit that referenced this pull request May 2, 2014
@hobu hobu merged commit e22d4f7 into master May 2, 2014
@hobu hobu deleted the issues/342-no-more-top-level-config.sh branch August 26, 2014 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants