Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pgpointcloud plugin by default #738

Merged
merged 1 commit into from
Feb 5, 2015

Conversation

gadomski
Copy link
Member

I think users on a blank or close-to-blank system should see as few cmake errors as possible — since this was on by default, a fresh build on a mostly fresh system would throw an error.

@strk
Copy link

strk commented Feb 3, 2015

ideally, the default should be based on the availability of dependencies on the system, building it if possible, and not if not possible

@gadomski
Copy link
Member Author

gadomski commented Feb 3, 2015

Something like: flip on the plugin if cmake's find_package(PostgreSQL) succeeds, but keep it off if it fails?

@strk
Copy link

strk commented Feb 3, 2015

Something like that, but I don't know what dependencies the pgpointcloud driver has exactly.

I think users on a blank or close-to-blank system should see as few
cmake errors as possible — since this was on by default, a fresh build
on a mostly fresh system would throw an error.
@gadomski
Copy link
Member Author

gadomski commented Feb 3, 2015

I've updated the pull request to quietly search for PostgreSQL, and use POSTGRESQL_FOUND to initialize the option.

@strk
Copy link

strk commented Feb 3, 2015

works for me (builds it, as desired)

hobu added a commit that referenced this pull request Feb 5, 2015
Disable pgpointcloud plugin by default
@hobu hobu merged commit 1a02abb into PDAL:master Feb 5, 2015
@gadomski gadomski deleted the postgres-off-by-default branch February 7, 2015 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants